Merged
Conversation
chedieck
requested changes
Jan 20, 2025
Collaborator
chedieck
left a comment
chedieck
left a comment
There was a problem hiding this comment.
Some issues with the code
utils/validators.ts
Outdated
| timestamp: 0, | ||
| opReturn: EMPTY_OP_RETURN | ||
| opReturn: EMPTY_OP_RETURN, | ||
| inputAddresses: [''] |
Collaborator
There was a problem hiding this comment.
This looks wrong. Should be [], that would be an empty input addresses list. [''] is a list with one input address, namely '', which is unnecessary.
services/triggerService.ts
Outdated
| buttonName: string | ||
| address: string | ||
| opReturn: OpReturnData | ||
| inputAddresses?: Array<string | undefined> |
Collaborator
There was a problem hiding this comment.
Why Array<string | undefined>? Should be string[], as in the other PRs.
lissavxo
force-pushed
the
feat/inputs-payment-trigger-option
branch
from
b42462d to
653c79e
Compare
chedieck
approved these changes
Jan 22, 2025
Collaborator
chedieck
left a comment
chedieck
left a comment
There was a problem hiding this comment.
LGTM. Is not present on the emails, but I suppose the aim of the issue is to implement in the POST trigger only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #916
Depends on
Description
Added input addresses variable to payment triggers options
Test plan